fix: correct stale function reference in tracing doc#358
Conversation
b16cbe4 to
53138d9
Compare
53138d9 to
3a660ba
Compare
|
Haven Xia (@HavenXia) would you mind taking a look when you get a chance, small doc fix? |
| All servers need to initialize an OpenTelemetry exporter and tracer provider. See `cmd/ateapi/ateapi.go:initTracing()` for an example: | ||
| All servers need to initialize an OpenTelemetry exporter and tracer provider. See `internal/serverboot.InitTracing()` (used by `cmd/ateapi/main.go`) for an example: | ||
|
|
||
| ```go |
There was a problem hiding this comment.
The code block has also been updated, can you update them also?
There was a problem hiding this comment.
The code block has also been updated, can you update them also?
thx, done!
|
Haven Xia (@HavenXia) Updated the code block to show the actual serverboot.InitTracing usage from cmd/ateapi/main.go. Could you take another look when you get a chance? |
already merged |
thx! |
2 participants
The tracing best practices doc points to cmd/ateapi/ateapi.go:initTracing() as the example, but that file/function does not exist. Servers now call internal/serverboot.InitTracing(), used in cmd/ateapi/main.go.
Verified internal/serverboot.InitTracing exists and is called from cmd/ateapi/main.go:80.